Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thunderBroker migration changes with config switch #675

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

nnaveen979
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this file?


tokio::spawn(async move {
while let Some(v) = response_tr.recv().await {
// check with thunder client callbacks and subscriptions
Copy link
Contributor

@pahearn73 pahearn73 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satlead : What's the purpose of ThunderClientManager here, is it supposed to receive requests and send them to a new thunder broker instance, and then it also listens for responses from that broker and sends the response back to the requestor? Trying to understand what @nnaveen979 needs to do here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a sample code he is supposed to delete this file

@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/675/rdkcentral/Ripple

  • Commit: 6566a42

Report detail: gist'

@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/675/rdkcentral/Ripple

  • Commit: de029ae

Report detail: gist'

Copy link

github-actions bot commented Dec 6, 2024

Code Coverage

Package Line Rate Health
core.main.src.processor 0%
core.main.src.service.extn 40%
core.sdk.src.api.manifest 91%
core.tdk.src.utils 0%
core.sdk.src.extn.ffi 80%
core.main.src.firebolt 3%
core.sdk.src.api.observability 48%
core.launcher.src 0%
core.sdk.src.extn.client 91%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.service.apps 47%
openrpc_validator.src 74%
device.thunder.src.bootstrap 0%
core.main.src.processor.storage 0%
core.main.src.utils 24%
core.sdk.src.api.gateway 68%
device.thunder_ripple_sdk.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors 10%
device.thunder_ripple_sdk.src 17%
device.thunder_ripple_sdk.src.events 4%
core.main.src.state.cap 43%
core.main.src.broker 45%
core.main.src.firebolt.handlers 9%
core.sdk.src.api.distributor 84%
core.sdk.src.utils 50%
core.tdk.src.gateway 100%
core.launcher.src.manager 7%
core.sdk.src.framework 75%
device.thunder.src 0%
core.main.src.state 23%
core.main.src.broker.thunder 22%
core.main.src.service 31%
core.main.src.bootstrap.extn 0%
core.sdk.src.api 78%
core.main.src 0%
core.sdk.src.api.device 76%
core.main.src.bootstrap 0%
core.sdk.src.extn 83%
device.mock_device.src 52%
device.thunder_ripple_sdk.src.client 59%
distributor.general.src 2%
core.main.src.bootstrap.manifest 0%
core.sdk.src.api.firebolt 77%
Summary 43% (18804 / 44191)

Minimum allowed line rate is 42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants