-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: thunderBroker migration changes with config switch #675
base: main
Are you sure you want to change the base?
Conversation
…etween thunderclient and thunderbroker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this file?
|
||
tokio::spawn(async move { | ||
while let Some(v) = response_tr.recv().await { | ||
// check with thunder client callbacks and subscriptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satlead : What's the purpose of ThunderClientManager
here, is it supposed to receive requests and send them to a new thunder broker instance, and then it also listens for responses from that broker and sends the response back to the requestor? Trying to understand what @nnaveen979 needs to do here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats a sample code he is supposed to delete this file
Minimum allowed line rate is |
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist