Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation advises to use methods instead of properties #4852

Open
npoltorapavlo opened this issue Jan 23, 2024 · 0 comments
Open

The documentation advises to use methods instead of properties #4852

npoltorapavlo opened this issue Jan 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@npoltorapavlo
Copy link
Contributor

The documentation says "API getters should start with get. For instance getDefaultInterface. Setters should start with set. For instance setDefaultInterface". Please remove this because it is misleading. For getters and setters the framework provides properties:

Property<CookieJarParamsData>(_T("cookiejar"), &WebKitBrowser::get_cookiejar, &WebKitBrowser::set_cookiejar, this);
@npoltorapavlo npoltorapavlo added the bug Something isn't working label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant