Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helpers/UtilsIarm.h #4863

Open
npoltorapavlo opened this issue Jan 26, 2024 · 0 comments
Open

Remove helpers/UtilsIarm.h #4863

npoltorapavlo opened this issue Jan 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@npoltorapavlo
Copy link
Contributor

npoltorapavlo commented Jan 26, 2024

By developing a module I expect it to be independent from other modules, or their order. I expect it should not be a problem if different modules call IARM_Bus_Init directly with different name in arbitrary order. The specification of IARM_Bus_Init looks like it should not be a problem either. Nevertheless the code of helpers/UtilsIarm.h expects that IARM is only used with name "Thunder_Plugins" and fails otherwise. I think this logic is a bug. If IARM is once inited and connected with different name all plugins that use helpers/UtilsIarm.h stop working. The problem would not exist if all modules implemented their own meaningful logic that accounts for simple situations like this, instead of relying on helpers/UtilsIarm.h. For example, this would work:

IARM_Bus_Init(__FUNCTION__);
IARM_Bus_Connect();
@npoltorapavlo npoltorapavlo added the bug Something isn't working label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant