Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colDef with cell parameter fails when using ReactR 0.6.0 #88

Closed
edelgado-ecdc opened this issue Aug 2, 2024 · 3 comments
Closed

colDef with cell parameter fails when using ReactR 0.6.0 #88

edelgado-ecdc opened this issue Aug 2, 2024 · 3 comments

Comments

@edelgado-ecdc
Copy link

Dear development team,

Thank you for your effort in maintaining one of the best table options for R!

Recently we started a new project and tried to render a table with HTML entities in it - something we've done a fair amount of times. However, when rendering the table, we found out that it simply wouldn't come up. After checking a few things we managed to identify the problem being ReactR 0.6.0 - when running with React 0.5.0 it works.

You can try this example from the reactable documentation:

library(reactable)
data <- MASS::Cars93[1:5, c("Manufacturer", "Model", "Type", "AirBags", "Price")]

reactable(data, columns = list(
    Model = colDef(cell = function(value, index) {
        # Render as a link
        url <- sprintf("https://wikipedia.org/wiki/%s_%s", data[index, "Manufacturer"], value)
        htmltools::tags$a(href = url, target = "_blank", as.character(value))
    }),
    AirBags = colDef(cell = function(value) {
        # Render as an X mark or check mark
        if (value == "None") "\u274c No" else "\u2714\ufe0f Yes"
    }),
    Price = colDef(cell = function(value) {
        # Render as currency
        paste0("$", format(value * 1000, big.mark = ","))
    })
))

Judging at the ReactR changelog there might be a couple of breaking changes with how it handles tags.

I couldn't find any recommendation on the version of reactR to use, but perhaps in the meantime it would be good to limit the version to 0.5.0.

Again, thanks for your effort on this library! :)

@FMKerckhof
Copy link

Could we potentially re-open this issue ? We are also affected by it and IMHO this is a bug that found it's way into 0.6.0 that blocks functionality of reactable as a reverse dependency. I am not well-versed enough in js to pinpoint where the issue lies exactly, but if there is anything that I could do w.r.t. testing potential patches, please let me know.

@edelgado-ecdc
Copy link
Author

Apologies! I was looking for this issue on both repos (reactable and reactR) and placed it on the wrong one. A colleague pointed it out and I closed it here to avoid further confusion - will open it on the right place as soon as I can :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants