Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Switches #4268

Merged
merged 2 commits into from
Aug 19, 2019
Merged

feat: add Switches #4268

merged 2 commits into from
Aug 19, 2019

Conversation

jquense
Copy link
Member

@jquense jquense commented Aug 16, 2019

closes: #4226

Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests + types?

www/src/pages/components/forms.js Outdated Show resolved Hide resolved
src/Switch.js Outdated Show resolved Hide resolved
@@ -0,0 +1,13 @@
<Form>
<Form.Check // prettier-ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

*
* @default 'custom-control'
*/
bsCustomPrefix: PropTypes.string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this intended to be used? I don't see it getting hit at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used below in the useBootstrap thing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean i don't see this ever getting overridden or anything demonstrating this getting overridden

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O it's more an escape hatch for a user, same as bsPrefix, since we are using custom-control in the same way it seemed good to also expose it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be good to document/demo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It documented i guess. I didn't want to make a big deal out of it and confuse normal users i guess!

@jquense jquense merged commit 98297c6 into master Aug 19, 2019
@jquense jquense deleted the custom-form branch August 19, 2019 17:14
@JeromeDeLeon
Copy link
Contributor

is this already push to the current version?

@mxschmitt
Copy link
Member

is this already push to the current version?

Nope, will be included in the next one.

@neylsongularte
Copy link

+1 for release to beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a switch component
5 participants