Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v5): Drop InputGroupPrepend and InputGroupAppend #5351

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

kyletsang
Copy link
Member

https://v5.getbootstrap.com/docs/5.0/forms/input-group/

Note:
I did run into an issue with the dropdowns that might need to be solved in another PR. The new markup for dropdowns has the dropdown toggle and menu directly under the InputGroup.

In v4 this was solved with <DropdownButton as={InputGroup.Prepend}>, but there's no parent element within InputGroup this time.

I don't think there's a way to solve this with the existing components... anybody have any suggestions?

Changes:

  • Drop InputGroupPrepend and InputGroupAppend
  • Replace input in InputGroupCheckbox with FormCheckInput
  • Fix tests and examples

- Replace input in InputGroupCheckbox with FormCheckInput
@jquense
Copy link
Member

jquense commented Aug 3, 2020

I did run into an issue with the dropdowns that might need to be solved in another PR. The new markup for dropdowns has the dropdown toggle and menu directly under the InputGroup.

react-bootstrap/react-overlays#843 may unlock some API improvements there, since we are trying to remove the need for Dropdown to render a wrapping element

@kyletsang
Copy link
Member Author

Thanks @jquense. I'll merge this one first.

@kyletsang kyletsang merged commit 8e73b63 into bs5-dev Aug 3, 2020
@kyletsang kyletsang deleted the v5-inputgroup branch August 3, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants