Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Modal's dialog and backdrop transition timeout #5837

Merged
merged 1 commit into from
May 27, 2021
Merged

Update Modal's dialog and backdrop transition timeout #5837

merged 1 commit into from
May 27, 2021

Conversation

sebammon
Copy link
Contributor

This PR addresses issue: #5788

When setting a transition that is longer than the default 300ms timeout as set by the Fade component's default props, the Modal is unmounted on exit before completing the animation. By setting the timeout=null for the Fade component, we let the Transition complete fully through the transitionEndListener.

@kyletsang kyletsang linked an issue May 27, 2021 that may be closed by this pull request
@kyletsang kyletsang merged commit e87e2ba into react-bootstrap:master May 27, 2021
@kyletsang
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot adjust modal transition duration
2 participants