Add suport for KML file (Only Markers) #2011
Conversation
example/App.js
Outdated
| @@ -142,7 +143,7 @@ class App extends React.Component { | |||
| [DefaultMarkers, 'Default Markers', true], | |||
| [CustomMarkers, 'Custom Markers', true], | |||
| [TakeSnapshot, 'Take Snapshot', true, '(incomplete)'], | |||
| [CachedMap, 'Cached Map'], | |||
| [CachedMap, 'Cached Map', true], | |||
There was a problem hiding this comment.
Returned to old value
| @@ -22,7 +22,7 @@ | |||
| <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" /> | |||
| <meta-data | |||
| android:name="com.google.android.geo.API_KEY" | |||
| android:value="AIzaSyBAefhRlXEH3vCko-zZTX6PHllTR6av4WI"/> | |||
| android:value="AIzaSyAJVwyHn6klk0_aoEL1oEysTOYn0jrRU1c"/> | |||
There was a problem hiding this comment.
Why? )) Does the old key work, doesn't it?
There was a problem hiding this comment.
Returned to old value
| @@ -18,4 +18,5 @@ Pod::Spec.new do |s| | |||
|
|
|||
| s.dependency 'React' | |||
| s.dependency 'GoogleMaps', '2.5.0' | |||
| s.dependency 'Google-Maps-iOS-Utils', '2.1.0' | |||
There was a problem hiding this comment.
I need it to convert the kml tags to Object
There was a problem hiding this comment.
Ah, I see now :)
+#import "GMUKMLParser.h"
+#import "GMUPlacemark.h"
+#import "GMUPoint.h"
+#import "GMUGeometryRenderer.h"
|
Great! Thank you for the contribution!!! LGTM |
docs/mapview.md
Outdated
| @@ -35,6 +35,7 @@ | |||
| | `loadingBackgroundColor` | `Color` | `#FFFFFF` | Sets loading background color, default to `#FFFFFF`. | |||
| | `moveOnMarkerPress` | `Boolean` | `true` | `Android only` If `false` the map won't move when a marker is pressed. | |||
| | `legalLabelInsets` | `EdgeInsets` | | If set, changes the position of the "Legal" label link from the OS default. **Note:** iOS only. | |||
| | `kmlSrc` | `string` | | The URL from KML file. **Note:** Google Maps only (either Android or iOS with `PROVIDER_GOOGLE`). | |||
There was a problem hiding this comment.
You say in the PR that it's markers only maybe we should specify this in the docs?
There was a problem hiding this comment.
Docs updated.
rafaellincoln
force-pushed
the
master
branch
from
8742a7d
to
2595a23
Compare
|
@rafaellincoln could you please fix the conflicts and #2011 (comment) 🤗 |
|
@rborn Fixed conflicts |
|
Hi there, @rafaellincoln thanks for this functionality! I've run the example that's in the docs (MapKml.js) but I can only see the markers running it on Android Studio, when running it on Genymotion it doesn't show nothing. @rborn can you confirm it? Also, it says (only markers) why? It works great with lines (LinearRing)! Thanks! |
Adds support for make marker with KML files.
Discussion on implementation at #967