adding onMyLocationChange event #2032

dabit1 · 2018-02-18T12:24:45Z

A fork from #1508 with no conflicts. Thanks so much @sagi . He is the author of the pull request and the thanks must go to him but It has conflicts since July, 2017. I think it is a great PR and must be merged.
I also added more data to event: altitude, accuracy, altitude_accuracy and speed.

@alvelig Please could you merge this awesome PR?

Regards,
David Escalera

rborn

@alvelig LGTM 🐽

alvelig · 2018-02-19T03:01:18Z

@dabit1 Thank you so much for such an important contribution!
May I ask you to make a simple example on how to use it (or how you use it)?

rborn · 2018-02-20T18:13:22Z

@dabit1 ping for docs/example 🤗

dabit1 · 2018-02-20T18:38:10Z

😂 I'm so busy sorry. Maximum Sunday I hope do that. El 20 feb. 2018 7:13 p. m., "Dan Tamas" <notifications@github.com> escribió:

…

@dabit1 <https://github.com/dabit1> ping for docs/example 🤗 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2032 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWN9bo5LNAQ6jkVBKl97beOIMS7nt0a4ks5tWwtHgaJpZM4SJq9S> .

bramus · 2018-02-20T23:03:20Z

Oh, this one would be awesome! Nice work!

dabit1 · 2018-02-24T11:37:17Z

@alvelig there is an example file changed with this new feature on this PR. Is it ok?

Bosseskompis · 2018-03-03T14:14:53Z

Any update on this?

alvelig · 2018-03-03T19:45:45Z

@dabit1 LGTM sorry for the delay, please resolve conflicts and we merge. Actually it's about adding from both branches.

alvelig · 2018-03-03T19:49:29Z

And also do you ming renaming onMyLocationChange to onUserLocationChange as it will be more consistent with showsUserLocation

rborn · 2018-03-03T22:07:12Z

+1 for renaming 🤗

…

Sent from my iPhone

On 3 Mar 2018, at 20:49, Alexander Veligurov ***@***.***> wrote: And also do you ming renaming onMyLocationChange to onUserLocationChange as it will be more consistent with showsUserLocation — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

dabit1 · 2018-03-03T22:10:17Z

Ey guys tomorrow afternoon I will do it. 😎 El 3 mar. 2018 11:07 p. m., "Dan Tamas" <notifications@github.com> escribió:

…

+1 for renaming 🤗 Sent from my iPhone > On 3 Mar 2018, at 20:49, Alexander Veligurov ***@***.***> wrote: > > And also do you ming renaming onMyLocationChange to onUserLocationChange as it will be more consistent with showsUserLocation > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2032 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWN9bhCG8B-ZdAafbR-gm2aBGNNih_2iks5taxQUgaJpZM4SJq9S> .

dabit1 · 2018-03-04T18:52:03Z

@alvelig done!

zerazeru · 2018-03-05T11:41:31Z

There's a } missing in AIRGoogleMap.m. PR's get merged without even trying to build before..? :/

Anyway, after fixing it, the event shows up, but it comes without all the location data (on ios).

bramus · 2018-03-05T20:54:00Z

Just tested out this PR using the example provided (up to the point before the rename) in the Android Emulator.

I had to disable the coordinate.putFloat() calls because it would not compile otherwise. Once I got it running it's not not working:

when playing back a .gpx file via the Emulator
when manually sending a new location to the Emulator

In both cases I don't see any location change events :(

Is it possible to revert this PR merge, awaiting a proper/better implementation? It'd also unbreak the master (see #2058) along with that.

bramus · 2018-03-06T12:18:17Z

With the hotfix above applied I've done some more testing in the Simulators:

iOS: builds + works
Android: builds + doesn't work (neither when playing back a .gpx file via the Emulator nor when sending over new location to the Emulator)

zerazeru · 2018-03-06T13:18:10Z

On iOS it builds for me but there is no event data (no coordinates), only a Proxy object. Does it work for you?

I noticed that it's the same for onPress, but for example for onRegionChange the proper event object is received.
Could it be related to RCTBubblingEventBlock / RCTDirectEventBlock ?

rborn · 2018-03-06T13:22:28Z

@bramus on android same issues with you no location is triggered, not even on android side - I've put a Log.v in the event (tested on a genymotion). Waiting for my android device to charge and I'll test for real too.

alvelig · 2018-03-06T13:24:00Z

I've tested in the Emulator with example. Does it work for you, guys?

rborn · 2018-03-06T13:24:51Z

@alvelig as I said, no

bramus · 2018-03-06T13:32:12Z

Same here @rborn (added some log statements in the handling Java code … no result).

On iOS I see the events come in @zerazeru (Tested with Debug > Location > Bicycle Ride):

rborn · 2018-03-06T13:52:32Z

@bramus @alvelig Ok, figured out, the example app doesn't ask for permissions on start 😳
You need to go and enable location manually in the Settings then it will work

bramus · 2018-03-06T14:02:36Z

Weird, as the AndroidManifest.xml file does require 'm:

    <uses-permission android:name="android.permission.ACCESS_COURSE_LOCATION"/>
    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

🤔

rborn · 2018-03-06T14:21:15Z

@bramus @alvelig this? https://stackoverflow.com/a/32636039/8018651

bramus · 2018-03-06T14:31:36Z

Aha, that could be it indeed … should we update the code to include something like https://github.com/yonahforst/react-native-permissions to request for location permissions first, in order to prevent confusion like we're having now? (I'm using this library in an already deployed app, works fine :))

rborn · 2018-03-06T14:35:39Z

I like that library too but I'm not sure if we should suggest using it in the docs or try to do it inside this module so we don't force the user to use an extra module.

On the other hand that library gives way more flexibility and would allow a better UX

🤔

alvelig · 2018-03-06T15:21:26Z

Consider #1489

bramus · 2018-03-06T19:34:16Z

I wouldn't include react-native-permissions in the core itself, as it would only broaden the surface react-native-maps is covering. Including in the examples (to make sure they work) and mentioning it in the documentation (to not confuse those checking out the examples, like I was now) should do the job.

For an app I built I created this “Permissions Required” component which uses react-native-permissions under the hood. The text is in Dutch, but you get the idea: it asks for permission to use your location, and only after having granted the required permissions the <MapView /> is being rendered.

With some adjustments this could make it into the examples.

rborn · 2018-03-07T10:57:58Z

@bramus I totally agree with adding some docs about this

aMarCruz · 2018-04-03T20:01:08Z

@dabit1 please add typings for all of us using Typescript :)

onUserLocationChange?: (value: {
    nativeEvent: { coordinate: {
        latitude: number,
        longitude: number,
        altitude: number,
        accuracy: number,
        speed: number,
        isFromMockProvider: boolean
    }}
}) => void;

dabit1 · 2018-04-03T21:34:17Z

@aMarCruz feel free to make a PR ;)

aMarCruz · 2018-04-04T22:23:41Z

@dabit1 , done :) PR is #2165

dabit1 · 2018-04-05T08:13:32Z

@aMarCruz well done!

AakashKB · 2018-05-21T17:59:16Z

For some reason, when I use onUserLocationChange, I get an undefined latitude and longitude.

My code:

<MapView
          ref={map => (this._mapView = map)}
          style={styles.map}
          showsUserLocation={true}
          showsPointsOfInterest={false}
          followsUserLocation={false}
          provider="google"
          region={this.state.region}
          onRegionChange={region => this.state.region = region}
          onUserLocationChange={location => alert(location.latitude)}
          onLongPress={event =>
            this.createMapEvent(event.nativeEvent.coordinate)
          }
        >

dabit1 · 2018-05-22T09:28:24Z

@AakashKB are permissions enabled?

AakashKB · 2018-05-23T15:44:58Z

@dabit1 yes, location permissions are enabled. showUserLocation works well.

AakashKB · 2018-05-23T16:36:40Z

I get this when I print out Object.keys(location). There is no key for latitude or longitude even returned.

David added 4 commits February 18, 2018 13:19

adding onMyLocationChange event

5820f06

adding onMyLocationChange event

f7d4547

adding more data to event

ceb0387

Merge branch 'master' of https://github.com/dabit1/react-native-maps

fb9d0bf

rborn reviewed Feb 18, 2018

View reviewed changes

alvelig mentioned this pull request Feb 23, 2018

Add user circle position tracking #2026

Closed

dabit1 and others added 2 commits March 4, 2018 19:46

Merge branch 'master' into master

bc6d515

change onMyLocationChange to onUserLocationChange

f5cf88f

from snake case to lower camel case

c198e08

alvelig mentioned this pull request Mar 4, 2018

onMyLocationChange Event for Google Maps (Android, iOS) #1508

Closed

alvelig merged commit 82c953d into react-native-maps:master Mar 4, 2018

alvelig mentioned this pull request Mar 4, 2018

Google Map Must move on location change #1937

Closed

This was referenced Mar 4, 2018

Feature Request: Provide onUserLocationChange for use with MapKit (iOS) #2055

Closed

Android doesn't compile with current master as dependency #2058

Closed

alvelig added a commit that referenced this pull request Mar 5, 2018

hotfix #2032

8f7bd9e

This was referenced Mar 8, 2018

Update maps SDK to get last features #2069

Closed

Get the position fetched from showsUserLocation #360

Closed

adding onMyLocationChange event #2032

adding onMyLocationChange event #2032

Conversation

dabit1 commented Feb 18, 2018 • edited Loading

rborn left a comment

Choose a reason for hiding this comment

alvelig commented Feb 19, 2018

rborn commented Feb 20, 2018

dabit1 commented Feb 20, 2018 via email

bramus commented Feb 20, 2018

dabit1 commented Feb 24, 2018

Bosseskompis commented Mar 3, 2018

alvelig commented Mar 3, 2018 • edited Loading

alvelig commented Mar 3, 2018

rborn commented Mar 3, 2018 via email

dabit1 commented Mar 3, 2018 via email

dabit1 commented Mar 4, 2018

zerazeru commented Mar 5, 2018 • edited Loading

bramus commented Mar 5, 2018

bramus commented Mar 6, 2018

zerazeru commented Mar 6, 2018

rborn commented Mar 6, 2018

alvelig commented Mar 6, 2018

rborn commented Mar 6, 2018

bramus commented Mar 6, 2018

rborn commented Mar 6, 2018

bramus commented Mar 6, 2018

rborn commented Mar 6, 2018

bramus commented Mar 6, 2018

rborn commented Mar 6, 2018

alvelig commented Mar 6, 2018

bramus commented Mar 6, 2018

rborn commented Mar 7, 2018

aMarCruz commented Apr 3, 2018 • edited Loading

dabit1 commented Apr 3, 2018

aMarCruz commented Apr 4, 2018

dabit1 commented Apr 5, 2018

AakashKB commented May 21, 2018

dabit1 commented May 22, 2018

AakashKB commented May 23, 2018

AakashKB commented May 23, 2018

dabit1 commented Feb 18, 2018 •

edited

Loading

alvelig commented Mar 3, 2018 •

edited

Loading

zerazeru commented Mar 5, 2018 •

edited

Loading

aMarCruz commented Apr 3, 2018 •

edited

Loading