Fix color prop types #2217
Merged
Fix color prop types #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use react-native's ColorPropType to validate the input
|
Ah, worth noticing that |
|
LGTM @alvelig 🐽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
Using react-native's
ColorPropTypeto validate all color props more accurately.More specifically I'm doing this to avoid getting yellow box alerts when using different formats for colors. For instance, using
setNormalizedColorAlpha()I have colors defined as integers in my app.How did you test this PR?
Just tested against my app, both in iOS and Android. Colors still work/no more alerts.