Fix peer dependencies warnings #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update peer dependencies - modified version notation of react-native. - use the release version of react
junkpiano
force-pushed
the
refactor/react-native-56
branch
from
8b3183c
to
47867bb
Compare
|
LGTM @alvelig 🐽 |
|
@alvelig ping ? 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
What issue is this PR fixing?
This PR will fix peer dependencies warnings when you run
npm installon the projects which are using React Native 0.56.0(or later). This relates to #2332 .How did you test this PR?
in my project,
node_modulesnpm installagainnpm install <relative path to react-native-maps> --saveHowever, it doesn't solve the warning around @babel-core@7.0.0-beta.38(required by @babel/plugin-check-constants@7.0.0-beta.38).