-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue: if 'isValid' value is used, mode and revalidationMode behaves like 'onChange' #944
Comments
Expected behavior, what's your use case? Why is this an issue? |
For example we have 2 async validation calls. So on every onChange they are fired. |
Please refer to the release log, it's 100% there. This is more of a DX improvement, so the user won't have to change to the specific mode in order to subscribe to invalid and it certainly works for some user who doesn't want to set it to onChange and still wants to subscribe to invalid. So this won't get revert back. |
Yeah i see it in the release logs. I mean the behaviour change should be documented in the docs (https://react-hook-form.com/) with 'isValid'. Thanks for your answer. We will try to live with it and find a solution for our problem :) |
Sure, I can include a note in the doc after work today. |
I will update the doc once we migrated to 18 to reduce conflicts before the merge: #940 |
Version Number
7.43.9
Codesandbox/Expo snack
https://codesandbox.io/s/react-hook-form-basic-forked-5gi2ng
Steps to reproduce
Based on the closed issue here react-hook-form/react-hook-form#10215 i try to "reopen" this bug.
It makes no sense, that this behaviour of 'isValid' has changed and that the issue was closed with the answer (react-hook-form/react-hook-form#10215 (comment))
Expected behaviour
isValid should not change useForm modes to onChange
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: