Superstruct v0.10 doesn't work

[federico-moretti]

Superstruct resolver doesn't work with the version 6.0.0, I tried the Yup resolver and it's working fine.

Steps to reproduce:

• Click submit
• It shows no errors and submit the values

https://codesandbox.io/s/currying-fire-um7b5

PS: thank you for the amazing library and hard work.

[bluebill1049]

Here is what i did: https://codesandbox.io/s/react-hook-form-v6-superstructresolver-ed67i?file=/src/App.js What's the correct usage for superstructure? i followed its doc.

[federico-moretti]

In your example the submit goes through even tho there are no values. In the Yup version if the validation fails it won't submit the form.

[bluebill1049]

In superstruct i think for required you will have to write the logic yourself: https://codesandbox.io/s/react-hook-form-v6-superstructresolver-ed67i?file=/src/App.js

[jgeschwendt]

I think the problem is the superstruct version. It looks like there were some breaking changes between 0.8.x and 0.10.x
https://github.com/ianstormtaylor/superstruct/blob/master/Changelog.md#0100--june-6-2020

[bluebill1049]

oh wow, i didn't know that. We are probably supporting the old version right now.

[bluebill1049]

We will support the old version for now then until more users want us to support that latest version.

[pix2D]

Would love support for the latest version. 👀

[bluebill1049]

Would love support for the latest version. 👀

send us a PR plz :)

[jgeschwendt]

I've played around with writing a resolver for the 0.10.x version but won't completely work until this issue gets fixed.

ianstormtaylor/superstruct#394

[bluebill1049]

oh, thanks a lot @jgeschwendt 🙏

[InSuperposition]

There is a PR open for the issue @jgeschwendt mentioned, hopefully, it will be merged soon.

ianstormtaylor/superstruct#440

[bluebill1049]

@InSuperposition the PR has been sitting there for months...

[zenflow]

@bluebill1049 It just got merged 🚀

[bluebill1049]

oh wow! that's awesome, please send us a PR if you got time, otherwise, I will have a look at it over the weekend. exciting, superstruct is going to be working as well 👍 thank you for your amazing PR at superstruct.

[zenflow]

@bluebill1049 Awesome! I probably won't be first to making the PR though since I'm not familiar with how react-hook-form works & I haven't even used it yet lol.. But it looks awesome and I'm excited to try it next time I need a form library. Thanks for maintaining it 🤗

[bluebill1049]

No worries @zenflow actually we probably can close this issue right? as long as the user starts to using 0.11?

[zenflow]

@bluebill1049 No I don't think we can close this yet. I saw a lot of changes in that project recently, including renaming some of the module exports. Probably those changes still need to be integrated here. A stable v1.0 release should come soon though ianstormtaylor/superstruct#491 (comment)

[bluebill1049]

@bluebill1049 No I don't think we can close this yet. I saw a lot of changes in that project recently, including renaming some of the module exports. Probably those changes still need to be integrated here. A stable v1.0 release should come soon though ianstormtaylor/superstruct#491 (comment)

Thanks for the update. Will keep an eye on the V1 then.

[jorisre]

@federico-moretti @pix2D & @InSuperposition Superstruct v0.10 supported ! You can update to the latest version of @hookfom/resolvers :) .