Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yupResolver): merge yup's options #172

Merged
merged 2 commits into from
May 31, 2021
Merged

fix(yupResolver): merge yup's options #172

merged 2 commits into from
May 31, 2021

Conversation

jorisre
Copy link
Member

@jorisre jorisre commented May 30, 2021

Related to #170 (comment)

@jorisre jorisre requested a review from bluebill1049 May 30, 2021 17:58
@jorisre jorisre linked an issue May 30, 2021 that may be closed by this pull request
Yup resolver { stripUnknown: true } schemaOption no longer working #170
Closed
@jorisre jorisre mentioned this pull request May 30, 2021
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2021 •
edited
Loading

Size Change: -2 B (0%)

Total Size: 19.8 kB

Filename Size Change
yup/dist/yup.js 567 B -1 B (0%)
yup/dist/yup.modern.js 505 B +2 B (0%)
yup/dist/yup.module.js 580 B -2 B (0%)
yup/dist/yup.umd.js 668 B -1 B (0%)
ℹ️ View Unchanged
Filename Size Change
class-validator/dist/class-validator.js 478 B 0 B
class-validator/dist/class-validator.modern.js 437 B 0 B
class-validator/dist/class-validator.module.js 499 B 0 B
class-validator/dist/class-validator.umd.js 583 B 0 B
computed-types/dist/computed-types.js 374 B 0 B
computed-types/dist/computed-types.modern.js 304 B 0 B
computed-types/dist/computed-types.module.js 386 B 0 B
computed-types/dist/computed-types.umd.js 469 B 0 B
dist/resolvers.js 190 B 0 B
dist/resolvers.modern.js 195 B 0 B
dist/resolvers.module.js 197 B 0 B
dist/resolvers.umd.js 292 B 0 B
io-ts/dist/io-ts.js 1.05 kB 0 B
io-ts/dist/io-ts.modern.js 1.08 kB 0 B
io-ts/dist/io-ts.module.js 1.12 kB 0 B
io-ts/dist/io-ts.umd.js 1.19 kB 0 B
joi/dist/joi.js 553 B 0 B
joi/dist/joi.modern.js 447 B 0 B
joi/dist/joi.module.js 567 B 0 B
joi/dist/joi.umd.js 659 B 0 B
nope/dist/nope.js 316 B 0 B
nope/dist/nope.modern.js 296 B 0 B
nope/dist/nope.module.js 327 B 0 B
nope/dist/nope.umd.js 403 B 0 B
superstruct/dist/superstruct.js 269 B 0 B
superstruct/dist/superstruct.modern.js 274 B 0 B
superstruct/dist/superstruct.module.js 282 B 0 B
superstruct/dist/superstruct.umd.js 367 B 0 B
vest/dist/vest.js 419 B 0 B
vest/dist/vest.modern.js 335 B 0 B
vest/dist/vest.module.js 389 B 0 B
vest/dist/vest.umd.js 508 B 0 B
zod/dist/zod.js 528 B 0 B
zod/dist/zod.modern.js 469 B 0 B
zod/dist/zod.module.js 541 B 0 B
zod/dist/zod.umd.js 636 B 0 B

compressed-size-action

@jorisre jorisre force-pushed the merge-yup-options branch from 5034175 to 07e965a Compare May 30, 2021 18:32
bluebill1049
bluebill1049 reviewed May 30, 2021
View reviewed changes
yup/src/yup.ts
](values, Object.assign({}, schemaOptions, { context }));
](
values,
Object.assign({ abortEarly: false }, schemaOptions, { context }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the merging 👍

bluebill1049
bluebill1049 approved these changes May 30, 2021
View reviewed changes
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jorisre

@jorisre jorisre merged commit 7bf09fd into master May 31, 2021
@jorisre jorisre deleted the merge-yup-options branch May 31, 2021 07:25
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluebill1049 bluebill1049 bluebill1049 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yup resolver { stripUnknown: true } schemaOption no longer working
2 participants
@jorisre @bluebill1049