Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong method referenced in validated input warning #715

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Fix wrong method referenced in validated input warning #715

merged 1 commit into from
Nov 24, 2021

Conversation

range-of-motion
Copy link
Contributor

Summary

Whenever you pass null as a value for .setItem(), you will see an error. It will tell you to use .remove instead, however that method doesn't exist, it should be .removeItem. I think so, at least 🤷

Test Plan

You can test this by throwing the error, see the example below.

import AsyncStorage from '@react-native-async-storage/async-storage';

AsyncStorage.setItem('bla', null);

@tido64 tido64 merged commit a3e9537 into react-native-async-storage:master Nov 24, 2021
@krizzu
Copy link
Member

krizzu commented Nov 24, 2021

🎉 This PR is included in version 1.15.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants