Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react-native-dom #1253

Merged
merged 6 commits into from
Sep 27, 2018
Merged

Support react-native-dom #1253

merged 6 commits into from
Sep 27, 2018

Conversation

cobarx
Copy link
Contributor

@cobarx cobarx commented Sep 27, 2018

This adds support for using react-native-video using the react-native-dom platform. react-native-dom is a complete implementation of React Native for the web.

Most props are implemented & working.

Remaining todo items:

  • Add event handlers
  • Document supported props
  • Test on browsers other than Chrome
  • If possible, make controls hide & appear by clicking on the video
  • Add fullscreen support

@cobarx
Copy link
Contributor Author

cobarx commented Sep 27, 2018

Ok, all the common props and events are there so I'm merging this!

The big missing piece is fullscreen support which is tricky because react-native-dom only has an async event handler model. To request fullscreen in a browser you must do it in a synchronous response to a user gesture like a key press or mouse click. I'm hoping I can get the react-native-dom maintainer to create a method to work around this since fullscreen is critical for web apps.

@cobarx cobarx merged commit 75e3a77 into master Sep 27, 2018
@cobarx cobarx deleted the feature/dom-support branch September 27, 2018 23:03
@cobarx cobarx changed the title [WIP] Support react-native-dom Support react-native-dom Sep 27, 2018
@sanderlooijenga
Copy link

sanderlooijenga commented Oct 5, 2018

Great work! When will this be released/published? 😃

@cobarx
Copy link
Contributor Author

cobarx commented Oct 5, 2018

This is available on master right now. I have a number of PRs to review and merge for 4.0, probably end of next week.

Be aware that this is a first pass, so some stuff may be buggy - like I need to handle browsers that don't allow autoplay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants