Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio mix with other apps for iOS #1978

Merged
merged 5 commits into from
May 7, 2020

Conversation

euharrison
Copy link
Contributor

This PR adds a feature to control how audio from video can mix with audios from others apps in iOS.

It's uses the options AVAudioSessionCategoryOptionMixWithOthers and AVAudioSessionCategoryOptionDuckOthers

It's helps #1103 and #959. It's also highly referenced by #403.

I'm not a iOS developer so please fells free to points to me any Obj-C error.

Sample:

<Video
  ...
  mixWithOthers="mix" // or "duck"
/>

@jenshandersson
Copy link
Contributor

This looks good to me @euharrison, I can see how this could be useful. Thanks for submitting it! Is there a similar property for Android we can implement?

@jenshandersson
Copy link
Contributor

I guess ignoreSilentSwitch is iOS only so then by that logic this can be added too :) Just make sure docs are clearly staging it's for iOS only.

@jenshandersson jenshandersson requested a review from cobarx May 5, 2020 15:35
@euharrison
Copy link
Contributor Author

Thanks that you appreciate @jenshandersson :)

I added the Platforms: iOS in the README. If you suggest to add it in another file, please let me know
https://github.com/react-native-community/react-native-video/pull/1978/files#diff-04c6e90faac2675aa89e2176d2eec7d8R541

@jenshandersson
Copy link
Contributor

Ah right, great. Can you add a line in the changelog as well @euharrison? Check other PRs to see how, basically a explanation and reference to PR

@euharrison
Copy link
Contributor Author

Done ✅

@jenshandersson jenshandersson merged commit c438509 into TheWidlarzGroup:master May 7, 2020
Copy link

@lousyfisherman07 lousyfisherman07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jsusj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants