Fix: OnNavigationStateChanged not always called #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added onCanGoBackChanged and onCanGoForwardChanged prop to webview (ios+android)
|
So I've tried to get this to work, but it doesn't appear to. import React, { Component } from "react";
import { WebView } from "react-native-webview";
export default class App extends Component<Props> {
render() {
const html = `
<html>
<head>
<script>
function changeurl() {
document.body.innerHTML += '<p>clicked</p>';
history.pushState({test: "test"}, "Test Title", "#hello");
document.body.innerHTML += '<p>done clicking</p>';
}
</script>
<style>body, button { font-size: 30px; padding: 30px; }</style>
</head>
<body>
<h1>Testing</h1>
<h1>Testing</h1>
<h1>Testing</h1>
<p>
<button onclick="javascript:changeurl()">Hello</button>
</p>
</body>
</html>
`;
return (
<WebView
source={{ html }}
onNavigationStateChange={nav => alert(JSON.stringify(nav))}
/>
);
}
}When I click the button, I see the appendChild fire, but the
|
|
Interesting -- it does work on Android.
|
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OnNavigationStateChangedProp of react-native-community-webview is not called when the history state is manipulated via javascript (e.g.:window.history.pushState({test: "test"}, "Test Title", "index.html")).With this pull request each history change will be noticed by the native webviews (android and ios) and the navigation change will be forwarded to
onNavigationStateChangedwithnavigationType: "other".