MapPolygon should support polygon hole

[therealgilles]

Apple Maps MkPolygon has support for interiorPolygons:
https://developer.apple.com/reference/mapkit/mkpolygon

Google Maps has support for polygon hole with an array of arrays in paths in google.maps.Polygon:
https://developers.google.com/maps/documentation/javascript/examples/polygon-hole

How can I get support for these in react-native-maps? Thank you

[therealgilles]

I've taken a stab at adding support for polygon holes for Google Maps on iOS. The changes below seem to work.

+++ b/traveller/ios/AirGoogleMaps/AIRGoogleMapPolygon.h
 @property (nonatomic, strong) NSArray<AIRMapCoordinate *> *coordinates;
+@property (nonatomic, strong) NSArray<NSArray<AIRMapCoordinate *> *> *holes;

+++ b/traveller/ios/AirGoogleMaps/AIRGoogleMapPolygon.m
   _polygon.path = path;
 }

+- (void)setHoles:(NSArray<NSArray<AIRMapCoordinate *> *> *)holes
+{
+  _holes = holes;
+
+  NSMutableArray<GMSMutablePath *> *interiorPolygons = [NSMutableArray array];
+  for(int h = 0; h < holes.count; h++)
+  {
+    // NSArray<AIRMapCoordinate *> *coordinates = [NSArray<AIRMapCoordinate *> coordinates];
+    // coordinates = holes[h];
+
+    // create path for interior polygon
+    GMSMutablePath *path = [GMSMutablePath path];
+    for(int i = 0; i < holes[h].count; i++)
+    {
+      [path addCoordinate:holes[h][i].coordinate];
+    }
+
+    // add path to holes array
+    [interiorPolygons addObject:path];
+  }
+
+  _polygon.holes = interiorPolygons;
+}
+
 -(void)setFillColor:(UIColor *)fillColor

+++ b/traveller/ios/AirGoogleMaps/AIRGoogleMapPolygonManager.m
 RCT_EXPORT_VIEW_PROPERTY(coordinates, AIRMapCoordinateArray)
+RCT_EXPORT_VIEW_PROPERTY(holes, AIRMapCoordinateArrayArray)

+++ b/traveller/ios/AirMaps/AIRMapPolygon.h
 @property (nonatomic, strong) NSArray<AIRMapCoordinate *> *coordinates;
+//@property (nonatomic, strong) NSArray *interiorPolygons;

+++ b/traveller/ios/AirMaps/RCTConvert+MoreMapKit.m 
 RCT_ARRAY_CONVERTER(AIRMapCoordinate)

++ (NSArray<NSArray<AIRMapCoordinate *> *> *)AIRMapCoordinateArrayArray:(id)json
+{
+    return RCTConvertArrayValue(@selector(AIRMapCoordinateArray:), json);
+}
+

[therealgilles]

Forgot this one in Components/MapPolygon.js:

   longitude: PropTypes.number.isRequired,
  })),
+
+  holes: PropTypes.arrayOf(PropTypes.arrayOf(PropTypes.shape({
+    /**
+     * Latitude/Longitude coordinates
+     */
+    latitude: PropTypes.number.isRequired,
+    longitude: PropTypes.number.isRequired,
+  }))),

[therealgilles]

See pull request #801 (iOS only).

[prjmax]

Is this feature going to be available for Android as well?

[alvelig]

@prjmax see #1781. It was merged finally!