Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust potential os.exit(1) for resource creation #141

Closed
endzyme opened this issue Jun 8, 2019 · 0 comments
Closed

Adjust potential os.exit(1) for resource creation #141

endzyme opened this issue Jun 8, 2019 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@endzyme
Copy link
Contributor

endzyme commented Jun 8, 2019

There is a call to config.GetConfigOrDie() in resource.go:123. This attempts to load the config, but if unsuccessful will call an os.Exit(1) from inside resourse.go.

From a user experience perspective it may be better to leverage config.GetConfig() and handle the err != nil by returning an empty ResourceProvider and an error message. Where this function is invoked, already has error handling which would capture a more usable message to the user instead of calling an os.Exit(1).

@endzyme endzyme added the good first issue Good for newcomers label Jun 8, 2019
@kimschles kimschles self-assigned this Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants