Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Enable variant Serializers - Newtonsoft, System.Text.Json #882

Closed
wants to merge 4 commits into from

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Feature - resolves #666

What is the current behavior?

Only allows for Newtonsoft serializer.

What is the new behavior?

Adds ability to switch Json Serializers.

What might this PR break?

Akavache will no longer have a default Json Serializer and users will need to add an additional package
Akavache.Newtonsoft OR Akavache.Json

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (7ed3a61) 61.05% compared to head (a48d5f3) 60.25%.

❗ Current head a48d5f3 differs from pull request most recent head 01be14d. Consider uploading reports for the commit 01be14d to get more accurate results

Files Patch % Lines
...rc/Akavache.NewtonsoftJson/NewtonsoftSerializer.cs 46.87% 24 Missing and 10 partials ⚠️
src/Akavache.Core/BlobCache/InMemoryBlobCache.cs 30.00% 12 Missing and 2 partials ⚠️
....NewtonsoftJson/JsonDateTimeOffsetTickConverter.cs 52.63% 5 Missing and 4 partials ⚠️
src/Akavache.Core/Json/JsonSerializationMixin.cs 0.00% 4 Missing ⚠️
...avache.NewtonsoftJson/JsonDateTimeTickConverter.cs 33.33% 1 Missing and 1 partial ⚠️
src/Akavache.NewtonsoftJson/Registrations.cs 86.66% 1 Missing and 1 partial ⚠️
....Sqlite3/SqlLiteCache/SqlRawPersistentBlobCache.cs 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   61.05%   60.25%   -0.80%     
==========================================
  Files          58       60       +2     
  Lines        2321     2370      +49     
  Branches      363      380      +17     
==========================================
+ Hits         1417     1428      +11     
- Misses        733      755      +22     
- Partials      171      187      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@listepo
Copy link

listepo commented Apr 9, 2024

any news?

@ChrisPulman
Copy link
Member Author

@listepo Unfortunately the features of the original Akavache use parts of Newtonsoft.Bson which there is no equivalent for System.Text.Json.
Reactivemarbles.CacheDatabase has support for both Newtonsoft.Json and System.Text.Json but is missing the features I described. If you are able to use the Reactivemarbles version then I would recommend this.

@ChrisPulman
Copy link
Member Author

Due to the fact that stripping all the features out will be an exact match to Reactivemarbles.CacheDatabase I am closing this PR

Copy link

github-actions bot commented Sep 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to choose json serializer
2 participants