Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename fromPromise to from #7

Closed
elvisbegovic opened this issue Apr 11, 2018 · 4 comments
Closed

rename fromPromise to from #7

elvisbegovic opened this issue Apr 11, 2018 · 4 comments
Assignees

Comments

@elvisbegovic
Copy link

I had "fromPromise" in my code which is correctly fixed by rxjs-tslint
from : import {fromPromise} from 'rxjs/observable/fromPromise'
to : import {fromPromise} from 'rxjs';

Problem is this is not available and renamed to from

Can we here be more smarter and rename it by the way ? :)

@mgechev
Copy link
Collaborator

mgechev commented Apr 11, 2018

The migration will update your code to rxjs 6 RC https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#600-terrific-rc3-2018-04-11. fromPromise resides in rxjs in this version.

@elvisbegovic
Copy link
Author

I'm using rc3 and can't see fromPromise, it seems replaced by from. see:https://github.com/ReactiveX/rxjs/blob/master/src/index.ts

@mgechev
Copy link
Collaborator

mgechev commented Apr 11, 2018

@istiti good catch!

@elvisbegovic
Copy link
Author

@mgechev by the same way use throwError instead _throw which not exist anymore in rxjs

mgechev added a commit that referenced this issue Apr 14, 2018
mgechev added a commit that referenced this issue Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants