Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(versioning): add versioning to docs website #5793

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

niklas-wortmann
Copy link
Member

No description provided.

"rxjs-dev": {
"hosting": {
"stable": [
"rxjs-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know much about this configuration. Can you explain what this is doing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, so we have one firebase project called rxjs-dev, we only use the hosting feature of firebase. Within firebase though we host now one "site" per version and those get an alias. So if you do firebase deploy --only hosting:stable it will deploy the current dist folder in the stable site. It's kinda like an alias for the site that is used within this branch

Copy link
Member

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Rebase and merge when you're ready.

I think the failure on the "latest" build is expected and we need to figure out how to make it optional on the 6.x branch. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants