Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition and CSSTransition component files import prop-types incorrectly #529

Closed
aaalrightalrightalright opened this issue Aug 2, 2019 · 2 comments · Fixed by #530
Closed

Comments

@aaalrightalrightalright
Copy link

What is the current behavior?

Currently, Transition and CSSTransition component files import prop-types as:

import * as PropTypes from 'prop-types';

What is the expected behavior?

All other components and files are importing prop-types in the expected way:

import PropTypes from 'prop-types';

I think a simple PR to just update these two files would suffice so there's consistent importing and usage of prop-types throughout.

@taion
Copy link
Member

taion commented Aug 2, 2019

We'd be happy to take such a PR.

@jquense
Copy link
Collaborator

jquense commented Aug 2, 2019

🎉 This issue has been resolved in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants