Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

turning pages on tap (left/right) doesn't work on iPad #2

Open
aferditamuriqi opened this issue Feb 9, 2018 · 5 comments
Open

turning pages on tap (left/right) doesn't work on iPad #2

aferditamuriqi opened this issue Feb 9, 2018 · 5 comments

Comments

@aferditamuriqi
Copy link
Member

From @aferditamuriqi on February 8, 2018 19:16

swipe works just fine in both landscape and portrait mode.

Copied from original issue: readium/r2-testapp-swift#16

@aferditamuriqi
Copy link
Member Author

I have some more info on this:
iOS 9.x: no taps
iOS 10.x: taps are working
iOS 11.x: taps are working as well

we still have the issue in Landscape on 10.x +
when the chapter end in odd page number, right tap is in the center of the screen

My suggestion:
an overall test of tap right/left for portrait/landscape on iPhone/iPad iOS 9,10,11
and see what needs to be addressed.

@aferditamuriqi
Copy link
Member Author

From @HadrienGardeur on February 8, 2018 22:9

We might want to move such issues to the new r2-glue-js repo, since this is entirely tied to the JS that we inject in those test apps. Thoughts?

@aferditamuriqi
Copy link
Member Author

you're correct, wasn't sure if this would be just a JS issue, since it seems to be only in iOS 9 though

@aferditamuriqi
Copy link
Member Author

From @HadrienGardeur on February 9, 2018 16:17

Taps are 100% implemented in JS while swipe is handled by the native code (you're either scrolling a webviews with snap points, or the scroll view that contains the webviews).

IMO on iOS the issue could be:

  • tied to JS itself
  • tied to the native callback in the JS

Can we migrate it to the new repo?

@aferditamuriqi
Copy link
Member Author

yes i will migrate it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant