Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPUB FXL] Panning in a zoom resource is broken #164

Closed
mickael-menu opened this issue Aug 6, 2020 · 8 comments · Fixed by readium/r2-navigator-kotlin#172
Closed

[EPUB FXL] Panning in a zoom resource is broken #164

mickael-menu opened this issue Aug 6, 2020 · 8 comments · Fixed by readium/r2-navigator-kotlin#172
Labels
bug Something isn't working

Comments

@mickael-menu
Copy link
Member

mickael-menu commented Aug 6, 2020

When a FXL resource is zoomed in, there's no way to move around the viewport by panning it, it's blocked.

Related issue: When rotating the device to landscape, the EPUB FXL is zoomed and clipped (since we can't pan around).

@mickael-menu mickael-menu added the bug Something isn't working label Aug 6, 2020
@johanpoirier
Copy link
Contributor

Hello, any idea why it is blocked? Or where the issue might be?

@mickael-menu
Copy link
Member Author

Not really, I didn't look into this issue yet. My first guess would be that the ViewPager's panning gesture is conflicting with the one from the WebView.

@johanpoirier
Copy link
Contributor

Is the panning supposed to be handled on the Kotlin side or on the WebView/JS side?

@mickael-menu
Copy link
Member Author

On the Kotlin side, by the WebView.

@johanpoirier
Copy link
Contributor

Has it ever worked in the past? Reading the code, I have the feeling that it has never been implemented.

@mickael-menu
Copy link
Member Author

Could be, I never saw it work.

@johanpoirier
Copy link
Contributor

This line is weird:

private fun internalMove(posX: Float, posY: Float, clamp: Boolean): Boolean {
     return internalMoveBy(posX - posX, posY - posY, clamp)
}

@johanpoirier
Copy link
Contributor

And this one too:

if (!NumberUtils.isEqual(posX, posX) || !NumberUtils.isEqual(posY, posY)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants