Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Daniel remove this line, it's particularly boring in thorium #21

Open
panaC opened this issue Jan 8, 2020 · 3 comments
Open

Comments

@panaC
Copy link
Member

panaC commented Jan 8, 2020

console.log("Link.Href is not set! (and no child Links)");

@danielweck
Copy link
Member

TODO: remove all instances of console.log() (not just in the _OnDeserialized() handlers), and replace with debug() where appropriate. This way, the DEBUG environment variable can be used to explicitly exclude unwanted messages from the console log:

https://github.com/visionmedia/debug#wildcards

@danielweck
Copy link
Member

Related issue: edrlab/thorium-reader#906

@danielweck
Copy link
Member

danielweck commented Jan 9, 2020

Note that this applies to all r2-xxx-js components, not just r2-shared-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants