Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font size option (user preference) does not work when defined explicitly in author-provided CSS #47

Closed
vincent-gros opened this issue May 9, 2014 · 2 comments
Closed

Font size option (user preference) does not work when defined explicitly in author-provided CSS #47

vincent-gros opened this issue May 9, 2014 · 2 comments

Comments

@vincent-gros
Copy link
Contributor

When the CSS file including in the EPUB file has explicit font size values like:
.medium { font-size: medium; }
The font size change option doesn't work.
This issue seems to be related to some functions in lib/ReaderSetingsDialog.js.
To see the problem, I made a sample, avaiable here.
@danielweck danielweck changed the title Readium doesn't change the font size when CSS file including in the EPUB file specifies explicit font values Font size option (user preference) does not work when defined explicitly in author-provided CSS Jul 7, 2014
@danielweck
Copy link
Member

moving this to readium-shared-js, as this is where settings are actually applied to the iframe's content document.

@danielweck danielweck mentioned this issue Jul 8, 2014
Closed
@danielweck
Copy link
Member

readium/readium-shared-js#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielweck @vincent-gros