fix: revert #1117 #1119
Merged
fix: revert #1117 #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e662654.
kanadgupta
changed the title
kanadgupta
deleted the
revert-1117-kanad-2024-12-10/remove-import-attributes
branch
|
🎉 This PR is included in version 9.0.3-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kanadgupta
added a commit
that referenced
this pull request
Dec 11, 2024
kanadgupta
added a commit
that referenced
this pull request
Dec 11, 2024
## 🧰 Changes we hit a bit of a wild edge case where the github action was only breaking in production builds due to how oclif loads the `package.json` and the only way we caught it was with [this failure](https://github.com/readmeio/rdme/actions/runs/12267183540/job/34226921877). this PR reverts #1119 (which in turn brings back #1117) with a slight tweak in f9461b4 to do the following: - make our import paths friendlier to github actions - manually copy over the `package.json` to our `dist/` directory whenever we run `npm run build`. TS was automatically handling this when we were using JSON imports before but now it's not able to pick up on the import so we have to copy it over ourselves. additionally in 669cb4f, i added a little check so we can catch these sorts of things better going forward. ## 🧬 QA & Testing Provide as much information as you can on how to test what you've done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1117 since it's evidently breaking GitHub Actions workflows 🤡