Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make imagemagick available at docker images #70

Closed
caduvieira opened this issue Jun 20, 2018 · 6 comments · Fixed by #84
Closed

Make imagemagick available at docker images #70

caduvieira opened this issue Jun 20, 2018 · 6 comments · Fixed by #84
Labels
Needed: design decision A core team decision is required

Comments

@caduvieira
Copy link

To be able to use sphinx plugin sphinx.ext.imgconverter to convert svg to png we need imagemagick available.

Refers: readthedocs/readthedocs.org#3979

@mgeier
Copy link
Contributor

mgeier commented Nov 12, 2018

@caduvieira IMHO it looks better most of the time if SVG images are converted to PDF images (instead of PNG) by using the sphinxcontrib-svg2pdfconverter module, which does the conversion without rasterizing the image.

See #78 and #79.

@humitos
Copy link
Member

humitos commented Jan 14, 2019

Hi all! imagemagick was installed in our latest testing image 5.0rc1 (not released yet). I'd like to know if you want to help us testing it. In that case, please let me know what are the projects you are interested on testing it and I will apply this Docker image for its building process.

@caduvieira
Copy link
Author

The project is:
servicosgovbr/manual-avaliacao
https://readthedocs.org/projects/manual-avaliacao/

The SVG image is in this anchor:
https://manual-avaliacao.readthedocs.io/pt_BR/latest/apresentacao.html#fluxo-simplificado-das-apis

Could you please test it? Thanks!

@humitos
Copy link
Member

humitos commented Jan 16, 2019

Hi @caduvieira! I enabled the new Docker image to your project and I triggered a new build of latest version. Please, let me know if it did work as you expected. Thanks!

@humitos
Copy link
Member

humitos commented Jan 16, 2019

@caduvieira it seems that you don't have the extension enabled/installed in your conf.py; readthedocs/readthedocs.org#3979 (comment)

@caduvieira
Copy link
Author

The build failed. I will try to correct this but i need to investigate.

https://pastebin.com/t9cYL3J4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants