From e70f73b2c0f657366578327dc289db29e18cba22 Mon Sep 17 00:00:00 2001 From: Santos Gallegos Date: Wed, 20 Feb 2019 17:32:04 -0500 Subject: [PATCH 1/2] Don't depend or specific data We are catching all exceptions here, but we are depending on self.project and self.version be correctly returned from the api. This doesn't always happens, and it's raising another error. --- readthedocs/projects/tasks.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readthedocs/projects/tasks.py b/readthedocs/projects/tasks.py index 39145b3189c..28aba1cb467 100644 --- a/readthedocs/projects/tasks.py +++ b/readthedocs/projects/tasks.py @@ -390,8 +390,8 @@ def run( 'stack': True, 'tags': { 'build': build_pk, - 'project': self.project.slug, - 'version': self.version.slug, + 'project': self.project.slug if self.project else None, + 'version': self.version.slug if self.version else None, }, }, ) From 8376557b99e28c703ce6a5df3b2844f3be2d9557 Mon Sep 17 00:00:00 2001 From: Santos Gallegos Date: Wed, 20 Feb 2019 17:50:11 -0500 Subject: [PATCH 2/2] Add comment --- readthedocs/projects/tasks.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/readthedocs/projects/tasks.py b/readthedocs/projects/tasks.py index 28aba1cb467..80be5d8342f 100644 --- a/readthedocs/projects/tasks.py +++ b/readthedocs/projects/tasks.py @@ -390,6 +390,9 @@ def run( 'stack': True, 'tags': { 'build': build_pk, + # We can't depend on these objects because the api + # could fail. But self.project and self.version are + # initialized as empty dicts in the init method. 'project': self.project.slug if self.project else None, 'version': self.version.slug if self.version else None, },