Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab Web Hook End-Point #1442

Closed
ghost opened this issue Jul 16, 2015 · 3 comments
Closed

Add GitLab Web Hook End-Point #1442

ghost opened this issue Jul 16, 2015 · 3 comments
Labels
Improvement Minor improvement to code
Milestone

Comments

@ghost
Copy link

ghost commented Jul 16, 2015

Need to add an end-point to Read the Docs to received on-push events from a GitLab installation.

The GitLab end-point would be similar to Read the Docs' existing GitHub support with only minor changes needed to support the slightly different response sent by a GitLab web hook POST.

POST body sent as a result of a push event is documented here.

@agjohnson agjohnson added this to the Gitlab milestone Jul 16, 2015
@agjohnson agjohnson added the Improvement Minor improvement to code label Jul 17, 2015
@ghost
Copy link
Author

ghost commented Jul 17, 2015

I would like to assign this to myself.

@ghost
Copy link
Author

ghost commented Jul 17, 2015

I just realized, there is test code for the GitHub end-point in test_post_commit_hooks.py. No Bitbucket tests though.

Should I add tests for GitLab? If so, how would I go about doing that since it seems the file is setup for only testing GitHub?

@agjohnson
Copy link
Contributor

Yes, we should have tests for integrations, including the missing ones for bitbucket. I'll open a separate issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

1 participant