Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict stable version to tags #1881

Closed
dschult opened this issue Dec 28, 2015 · 2 comments
Closed

restrict stable version to tags #1881

dschult opened this issue Dec 28, 2015 · 2 comments
Labels
Improvement Minor improvement to code Needed: more information A reply from issue author is required

Comments

@dschult
Copy link

dschult commented Dec 28, 2015

We create a tagged version of our github repo for each release. But we also have branches and sometimes the branch name parses to a version more recent than our stable tag. So the branch becomes the "stable" release on readthedocs. It'd be nice to restrict the choice of the "stable" release to only be from the github tags instead of including both tags and branches.

We can of course be very careful how we name our branches. But that choice is rarely done with readthedocs in mind and its a surprise when the stable docs suddenly change because we created a branch in the repository.

Perhaps this is just a github issue, but I suspect it has wider impact too.

[workarounds and other options would be appreciated too]

@kmike
Copy link

kmike commented Apr 28, 2016

This issue affects Scrapy: version names in Scrapy docs don't make any sense now. "Latest" points to 1.0, "stable" points to upcoming 1.1 and "master" points to master (upcoming 1.2). So latest is the oldest, and stable is not released yet.

I'm not sure how we got here :) It might be an error on our side, but it is not clear how to fix it.

@humitos
Copy link
Member

humitos commented Dec 29, 2017

This logic was implemented at #3331

Please, would you mind confirming if you still have this issue? I think it should have solved now. If the problem is gone, please close the issue :)

@humitos humitos added the Needed: more information A reply from issue author is required label Dec 29, 2017
@dschult dschult closed this as completed Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: more information A reply from issue author is required
Projects
None yet
Development

No branches or pull requests

4 participants