Clean up HTML for donate app

[ericholscher]

More information here: #2503 (review)

[Riyuzakii]

@ericholscher, i am a first timer and i would like to contribute. could explain the issue a bit and direct me to the files that need to be changed.

[ericholscher]

The first step would be to clean up the HTML as suggested in that pull request. It uses <strong> where it should be doing it with CSS. @agjohnson might be able to give more concrete suggestions on the best steps to take.

[Riyuzakii]

@ericholscher , @agjohnson can you direct me to the files that need to be changed.

[agjohnson]

@Riyuzakii all the files that need to be changed are in the review feedback. I'd prefer to remove HTML styling and instead add css rules in https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/core/static/core/css/theme.css

If you clean up the Knockout implementation, you'll be playing with this file:
https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/donate/static-src/donate/js/donate.js

Sorry I don't have time for more direct guidance. Feel free to raise any questions you run into here and we'll try to point you in the right direction.

[krsion]

Has anyone resolved this issue? I'd like to contribute.

[bytetwin]

@agjohnson For replacing the strong tag into css, I looked at static/core/css/theme.css and the css seems to be minified version. Also I could find few style in the html elements in promo_detail.html.

Am I missing something here. Also could you please let me know on how to test my changes as http://127.0.0.1:8000/sustainability/report/live/ - gives me no such promos - which means I need to create promos. How do I create one

[monvilafer]

Hi everyone, has anyone solved this issue?
If not, can I work on it?

[Tikam02]

@agjohnson clean-up the css/theme.css. check it once so that i can PR it.

[davidfischer]

To be 100% honest, I think this issue can be closed. The donate app has been moved out of this repository.

[Tikam02]

@ericholscher actually i saw the whole code for js/css/html , sorry to say that but it's not formatted properly can i clean-up the codes.for better understanding.

[stsewd]

@Tikam02 you can check this PR for reference #2699 (was closed due inactivity)

[agjohnson]

Closing, this isn't valid anymore as the source has moved.