-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build static assets #4280
Comments
I think this was something to do with the node version. |
Any idea of what version of nodejs to use ? |
$ node --version
v10.0.0 $ npm --version
5.6.0 |
I have the same issue, and have had trouble debugging it, so I'd love to see if we find a fix for this. |
After some investigations, the |
I'm able to build the minified js version with the above node and npm versions btw. |
@stsewd is the |
I had some similar problems and I used node 9.2.1 and worked. I don't know the root cause of the issue though.
|
Thanks @humitos, but i have test with node 9.2.1 and it doesn't work for the |
I haven't re-downloaded the dependencies in a long time, so probably the problem is there 🤔 |
FWIW, I've tested with 9.2.1 and fresh dependencies and can rebuild without issue. |
I am pretty certain this has to do with one of the dependencies and not with node/npm itself. If I clear all the dependencies and rebuild, I see this issue.
I tried both node v8.11.3 (the latest LTS as of this comment) and node v6.9.4 with npm v6.1.0 and I see the issue with both node versions. I think the |
I see this as well and it is odd |
I get this exception when I run
|
I believe I have a fix for this issue #4311 if any of you folks would be willing to test it. |
I have modified the file
readthedocs/core/static-src/core/js/readthedocs-doc-embed.js
and use thegulp build
command to regenerate the static assets:The problem is that the
readthedocs/core/static/core/js/readthedocs-doc-embed.js
is not regenerated.The text was updated successfully, but these errors were encountered: