Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate user input URLs on redirect form #4555

Closed
humitos opened this issue Aug 22, 2018 · 3 comments · Fixed by #10881
Closed

Validate user input URLs on redirect form #4555

humitos opened this issue Aug 22, 2018 · 3 comments · Fixed by #10881
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone

Comments

@humitos
Copy link
Member

humitos commented Aug 22, 2018

There are cases where allowing the user to input a To URL without a leading slash produce weird redirects. See #4501 (comment)

Besides the case described in that comment, there are other that needs to be validated. For example when we redirect to external sites, this should allow a URL that starts with http for example.

I pushed a commit for one of these cases at f6fed2d but I also realize that we are using jQuery to dynamically change the inputs of the form. This is a problem when the form returned a validation error since it starts with the default state (no inputs at all) and a red error message which could confuse even more our users.

@humitos humitos added the Improvement Minor improvement to code label Aug 22, 2018
@humitos humitos added this to the Admin UX milestone Aug 22, 2018
@stsewd
Copy link
Member

stsewd commented Aug 24, 2018

Related to #4023

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
@stsewd
Copy link
Member

stsewd commented Jan 14, 2019

Should we allow URLs without / at the beginning? I mean, for no-external urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants