Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation list Jan 2019 & RTD v3.0 #4594

Closed
agjohnson opened this issue Aug 30, 2018 · 14 comments
Closed

Deprecation list Jan 2019 & RTD v3.0 #4594

agjohnson opened this issue Aug 30, 2018 · 14 comments
Labels
Needed: design decision A core team decision is required
Milestone

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Aug 30, 2018

We've talked about deprecating a number of things in Jan 2019, so let's make official plans and get things announced for a v3.0. Here are things on the chopping block:

@agjohnson agjohnson added the Needed: design decision A core team decision is required label Aug 30, 2018
@agjohnson agjohnson added this to the 3.0 milestone Aug 30, 2018
@stsewd
Copy link
Member

stsewd commented Aug 30, 2018

any reason to keep python2 support now?

.com is still running py2 I think.

@davidfischer
Copy link
Contributor

davidfischer commented Aug 30, 2018

I would like to get rid of all dashboard access over HTTP including the API. Basically all this stuff should forward to HTTPS. This has been announced in the docs and on the blog.

@stsewd
Copy link
Member

stsewd commented Aug 30, 2018

Also, our current version of django, not sure if other people are using a heavily customized fork of rtd that could cause problems.

@davidfischer
Copy link
Contributor

Anything to do with mkdocs? I think deprecating < v1.0 is pretty aggressive, but there might be a less aggressive method

I don't know how we do this in practice. Nothing stops people from just putting mkdocs<1.0 in their requirements file. I would be +1 on locking down versions of Sphinx/MkDocs based on something in the YAML file and it can't be overridden with a requirements file. That way we can deprecate versions of Sphinx/MkDocs.

@davidfischer
Copy link
Contributor

Also, our current version of django, not sure if other people are using a heavily customized fork of rtd that could cause problems.

I would not let that slow us down. If we could get to Django 1.11 before January, that would be amazing.

@agjohnson
Copy link
Contributor Author

Yeah, I'm about 100% not concerned with forks of RTD for our development roadmap. I'm a big 👍 on migrating to modern Django.

@agjohnson
Copy link
Contributor Author

.com is still running py2 I think.

It is, but this isn't blocking us on deprecating.

@agjohnson
Copy link
Contributor Author

I would like to get rid of all dashboard access over HTTP including the API. Basically all this stuff should forward to HTTPS. This has been announced in the docs and on the blog.

I don't think there is anything to deprecate here, we'll just start redirecting links. 3 of those 4 endpoints are being deprecated anyways, so we just need to worry about the /api endpoint.

@stsewd
Copy link
Member

stsewd commented Sep 20, 2018

Can we include #2663 here?

@agjohnson
Copy link
Contributor Author

I guess it probably does make sense to include this in our list of changes we should notify on. We can do this before v3.0 perhaps?

@humitos
Copy link
Member

humitos commented Oct 27, 2018

I think we should default to Python 3 by adding default=3 as database level also: #3070. Actually, I've already did this before but I closed it for some reason:#4613

@stsewd
Copy link
Member

stsewd commented Oct 27, 2018

Actually, I've already did this before but I closed it for some reason:#4613

@humitos it was because there is another PR already p: (#3581)

@ericholscher
Copy link
Member

+1 on removing python2 support. We should likely do that in an RTD v3.

I think the main thing here is to see who is using the old endpoints, and make a plan to email them about it. It should be a pretty simple thing to change, I hope, but we should definitely alert folks who are hitting /build for example in custom scripts of a migration path.

@agjohnson
Copy link
Contributor Author

Endpoint deprecations are found at #4568, we'll want to tackle that very soon to start the notification process. We need a month or two ideally.

It doesn't seem there is much to do with Mkdocs. Break out a separate ticket if there is and apply to v3 milestone.

We'll discuss removing privacy levels with v3 as well, that may be a later deprecation.

I'll close this as discrete tickets are more helpful now that we've discussed the overall plan i think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

5 participants