Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for send_notifications on VersionLockedError #4840

Closed
humitos opened this issue Oct 31, 2018 · 1 comment
Closed

Add test case for send_notifications on VersionLockedError #4840

humitos opened this issue Oct 31, 2018 · 1 comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: tests Tests are required

Comments

@humitos
Copy link
Member

humitos commented Oct 31, 2018

To avoid #4839 to happen again, it would be good to have some good test cases to check that we are not sending any kind of notification when the version is locked.
@humitos humitos added Improvement Minor improvement to code Needed: tests Tests are required Accepted Accepted issue on our roadmap labels Oct 31, 2018
@humitos humitos mentioned this issue Oct 31, 2018
Merged
@dojutsu-user
Copy link
Member

@humitos
I want to take this issue.
Can you please guide me on where to add tests and if there are some similar tests so that I can learn from them on how to solve this issue.

@dojutsu-user dojutsu-user mentioned this issue Dec 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: tests Tests are required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humitos @dojutsu-user