Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github signed webhook #4886

Closed
3 tasks
agjohnson opened this issue Nov 10, 2018 · 0 comments
Closed
3 tasks

Github signed webhook #4886

agjohnson opened this issue Nov 10, 2018 · 0 comments
Assignees
@stsewd
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone
3.3

Comments

@agjohnson
Copy link
Contributor

GitHub supports signing a webhook with a key. We should support this and configure the signing key on webhook set up. I believe GitLab might have something similar, but Bitbucket does not?

Requirements:

  • Add model field for signature
  • Store signature on webhook creation
  • Validate webhook post with signature
@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Nov 10, 2018
@agjohnson agjohnson added this to the 2.10 milestone Nov 10, 2018
@agjohnson agjohnson mentioned this issue Nov 10, 2018
Closed
@stsewd stsewd self-assigned this Nov 29, 2018
@stsewd stsewd mentioned this issue Dec 5, 2018
Merged
@agjohnson agjohnson modified the milestones: 3.2, 3.3 Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stsewd stsewd

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
2 participants
@agjohnson @stsewd