Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds fail with no 'master' branch #4890

Closed
MTecknology opened this issue Nov 11, 2018 · 5 comments
Closed

Builds fail with no 'master' branch #4890

MTecknology opened this issue Nov 11, 2018 · 5 comments
Assignees
Labels
Needed: replication Bug replication is required

Comments

@MTecknology
Copy link

MTecknology commented Nov 11, 2018

It seems RTD is unable to import/build my project if there is no 'master' branch, even though the default branch is 'develop'. If I create a master branch, builds will start succeeding.

After reading the logs, it looks a lot like the build process has 'master' hard coded into a few places.

@stsewd
Copy link
Member

stsewd commented Nov 12, 2018

I believe this should only pass once when first importing the project, rtd doesn't have the versions, it clones the repo, checkout to master, and then sync the versions.

That step can be done before the checkout, I think when #4259 is fixed, will cover this case too.

I'll search if this only happens on the first import or in some other places later.

@stsewd stsewd added the Needed: replication Bug replication is required label Nov 12, 2018
@MTecknology
Copy link
Author

MTecknology commented Nov 13, 2018

I tried adding the branch to the project for an initial import and then the docs could build. After deleting the branch, builds stopped working again.

I just tried rebuilding: https://readthedocs.org/api/v2/build/8091150.txt

@stsewd stsewd self-assigned this Nov 13, 2018
@stsewd
Copy link
Member

stsewd commented Nov 13, 2018

After deleting the branch, builds stopped working again.

But did you change the default branch to be develop? Maybe a build to master was triggered by a webhook? Can you check the webhook responses? (if there is a push to develop, what branches are marked to build)

@MTecknology
Copy link
Author

I thought I tried that, but I just tried again and it seems to be working. I guess it /is/ the same thing. Thanks!

@stsewd
Copy link
Member

stsewd commented Nov 14, 2018

Well, when the other problem gets fixed, the first build will still fail, but you won't need to create a master branch because there will be another branch (develop) in the list of available versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: replication Bug replication is required
Projects
None yet
Development

No branches or pull requests

2 participants