Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to built HTML in a post_build job do not show up in the site preview #9797

Closed
choldgraf opened this issue Dec 11, 2022 · 4 comments

Comments

@choldgraf
Copy link
Contributor

choldgraf commented Dec 11, 2022

Details

I am experimenting with using staticrypt to encrypt some HTML files that are built with Sphinx before being uploaded to RTD. To do so, I'm using a post_build event that modifies the built HTML and replaces it with an encrypted version. However, in the PR preview these changes do not seem to propagate.

For example:

Project info:

Expected Result

I expected the page to be hidden behind a password, similar to other pages with staticrypt.

Actual Result

The page is viewable to anyone.

@humitos
Copy link
Member

humitos commented Dec 12, 2022

Hi Chris! It seems that you are hitting this bug #9172 which will be solved by #9179

The problem here is that Read the Docs is moving the output of the build process immediately after build and before running post_build. That should not work like that.

I suggest you to subscribe to #9179 to get updates about this. That issue is already in our roadmap, so we plan to fix it in the following weeks/months.

I think this issue could be closed as duplicated.

@stsewd stsewd closed this as completed Dec 19, 2022
@choldgraf
Copy link
Contributor Author

Is this completed now? I see that this one is still open

@humitos
Copy link
Member

humitos commented Dec 20, 2022

It's not complete, no. I'd assume that @stsewd closed this issue as duplicated of #9179, maybe? @stsewd can you confirm?

@choldgraf
Copy link
Contributor Author

choldgraf commented Dec 20, 2022

Ah I see - I was just confused when I saw the "completed" notification. In case it is helpful, FYI you can close issues as notplanned / duplicated etc by clicking the drop-down arrow before clicking the close button:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants