From 086b0610a219ed0d08fcec6274e4da2312eac9ac Mon Sep 17 00:00:00 2001
From: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Date: Wed, 23 May 2018 11:57:00 +0200
Subject: [PATCH] oauth/services: don't abuse log.exception

log.exception should not be used outside exception handlers
---
 readthedocs/oauth/services/bitbucket.py | 4 ++--
 readthedocs/oauth/services/github.py    | 4 ++--
 readthedocs/oauth/services/gitlab.py    | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/readthedocs/oauth/services/bitbucket.py b/readthedocs/oauth/services/bitbucket.py
index 1d93b99593f..0e9976669dd 100644
--- a/readthedocs/oauth/services/bitbucket.py
+++ b/readthedocs/oauth/services/bitbucket.py
@@ -230,7 +230,7 @@ def setup_webhook(self, project):
                 project,
             )
         else:
-            log.exception(
+            log.error(
                 'Bitbucket webhook creation failed for project: %s',
                 project,
             )
@@ -287,7 +287,7 @@ def update_webhook(self, project, integration):
                 project,
             )
         else:
-            log.exception(
+            log.error(
                 'Bitbucket webhook update failed for project: %s',
                 project,
             )
diff --git a/readthedocs/oauth/services/github.py b/readthedocs/oauth/services/github.py
index 654adca4da4..58a569c04a5 100644
--- a/readthedocs/oauth/services/github.py
+++ b/readthedocs/oauth/services/github.py
@@ -214,7 +214,7 @@ def setup_webhook(self, project):
                 project,
             )
         else:
-            log.exception(
+            log.error(
                 'GitHub webhook creation failed for project: %s',
                 project,
             )
@@ -274,7 +274,7 @@ def update_webhook(self, project, integration):
                 project,
             )
         else:
-            log.exception(
+            log.error(
                 'GitHub webhook update failed for project: %s',
                 project,
             )
diff --git a/readthedocs/oauth/services/gitlab.py b/readthedocs/oauth/services/gitlab.py
index 27ce92f26f2..240c6bbfd54 100644
--- a/readthedocs/oauth/services/gitlab.py
+++ b/readthedocs/oauth/services/gitlab.py
@@ -305,7 +305,7 @@ def setup_webhook(self, project):
                 project,
             )
         else:
-            log.exception(
+            log.error(
                 'GitLab webhook creation failed for project: %s',
                 project,
             )
@@ -363,7 +363,7 @@ def update_webhook(self, project, integration):
             log.exception(
                 'GitLab webhook update failed for project: %s', project)
         else:
-            log.exception(
+            log.error(
                 'GitLab webhook update failed for project: %s',
                 project,
             )