Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule request: if ... != nil over if let _ = .... #1116

Closed
marcelofabri opened this issue Jan 5, 2017 · 1 comment
Closed

Rule request: if ... != nil over if let _ = .... #1116

marcelofabri opened this issue Jan 5, 2017 · 1 comment
Labels
rule-request Requests for a new rules.

Comments

@marcelofabri
Copy link
Collaborator

From this comment:

Please use if ... != nil rather than if let _ = .... We ought to have a rule for this.
@marcelofabri marcelofabri added the rule-request Requests for a new rules. label Jan 5, 2017
@jpsim
Copy link
Collaborator

jpsim commented Jan 5, 2017

Sure, I'm always in favor of adapting SwiftLint to reflect the conventions already followed throughout a code base.

Although my feelings on this haven't changed since this twitter convo from nearly 2 years ago: https://twitter.com/danituits/status/594641421925273602

@rakaramos rakaramos mentioned this issue Jan 5, 2017
Merged
@klaaspieter klaaspieter mentioned this issue Apr 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule-request Requests for a new rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsim @marcelofabri