Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive on syntactic_sugar rule #1508

Closed
JohnEstropia opened this issue May 12, 2017 · 1 comment
Closed

False positive on syntactic_sugar rule #1508

JohnEstropia opened this issue May 12, 2017 · 1 comment
Labels
bug Unexpected and reproducible misbehavior.

Comments

@JohnEstropia
Copy link
Contributor

JohnEstropia commented May 12, 2017 •
edited
Loading

I have a nested type named <SomeClass>.Optional and swiftlint thinks this is Swift.Optional so I am getting the following warning:
screen shot 2017-05-12 at 18 42 27
@marcelofabri marcelofabri added the bug Unexpected and reproducible misbehavior. label May 12, 2017
@marcelofabri
Copy link
Collaborator

This shouldn't be too hard to fix: basically we should not trigger if there's a . before the type. We should trigger on Swift.Optional<Int> though. Do you wanna take a look at it?

@marcelofabri marcelofabri mentioned this issue May 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelofabri @JohnEstropia