You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I added another reporter for SonarQube.
I conducted tests on my personal applications, and found my patch works fine and sents collect data.
It looks like this.
The difference is that the issue has SwiftLint tag besides the issue description.
We can continuously check our code violations on SonarQube.
On the other hand, there is a limitation. We cannot use character in the JSON we send.
I took a look at SonarQube code, where I got a java exception error.
If startColumn(= character in SwiftLint) is specified, it throws null pointer exception, since SwiftLint StyleViolation doesn't have endColumn, and endLine. So I skipped startColumn intentionally to avoid the exception.
That said, it's appreciated if you consider adding this feature to SwiftLint.
New Issue Checklist
Proposal
This is a new feature proposal.
Looking at #175 , SwiftLint was integrated by SonarQube plugin.
Now SonarQube 7.2 provides the way to import issues from the 3rd party analyzers.
So I added another reporter for SonarQube.
I conducted tests on my personal applications, and found my patch works fine and sents collect data.
It looks like this.
The difference is that the issue has
SwiftLint
tag besides the issue description.We can continuously check our code violations on SonarQube.
On the other hand, there is a limitation. We cannot use
character
in the JSON we send.I took a look at SonarQube code, where I got a java exception error.
https://github.com/SonarSource/sonarqube/blob/4bccde70aab57079a0c7b6055528f776fac315fe/sonar-scanner-engine/src/main/java/org/sonar/scanner/externalissue/ExternalIssueImporter.java#L120
If startColumn(=
character
in SwiftLint) is specified, it throws null pointer exception, since SwiftLintStyleViolation
doesn't have endColumn, and endLine. So I skippedstartColumn
intentionally to avoid the exception.That said, it's appreciated if you consider adding this feature to SwiftLint.
My code is junkpiano@eaff52c.
If you are OK with it, I can send PR.
The text was updated successfully, but these errors were encountered: