Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble_operator rule is not triggered for beTrue() #2613

Closed
Igor-Palaguta opened this issue Jan 30, 2019 · 2 comments
Closed

nimble_operator rule is not triggered for beTrue() #2613

Igor-Palaguta opened this issue Jan 30, 2019 · 2 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@Igor-Palaguta
Copy link

Describe the bug

nimble_operator rule is not triggered for beTrue() Nimble's predicate

Environment

  • SwiftLint version (run swiftlint version to be sure)?
    0.30.1
  • Installation method used (Homebrew, CocoaPods, building from source, etc)?
    package file from github
  • Paste your configuration file:
opt_in_rules:
  - nimble_operator
  • Which Xcode version are you using (check xcode-select -p)?
    Version 10.0 (10A255)
  • Do you have a sample that shows the issue?

echo "expect(success).to(beTrue())" | swiftlint lint --no-cache --use-stdin --enable-all-rules

// This triggers a violation:
expect(success).to(beTrue())

// This does not trigger a violation:
expect(success) == true
@marcelofabri marcelofabri added the enhancement Ideas for improvements of existing features and rules. label Jan 30, 2019
@marcelofabri
Copy link
Collaborator

I think it was a conscious decision when I first wrote that rule because I personally preferred to use to(beTrue()) at that time.

But we should catch this though. PRs are welcome!

@marcelofabri
Copy link
Collaborator

Implemented in #2622.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Development

No branches or pull requests

2 participants