-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't compile on Linux with Swift 5.1 #2874
Comments
I looked at it in a bit more detail. The dependency is pulled in by SourceKitten, which has been updated such that it also fetches the fixed version of SWXMLHash. However, the SourceKitten update also introduces new enum cases for some of its types, which means that the relevant places in the SwiftLint source that use those enums need to be updated in order for this to compile. |
I experience this same issue on macOS compiling Swiftlint from scratch |
In macOS this issue was fixed using SourceKitten at |
Now it fails with a different error (repeated a couple of times):
|
Have you tried to fix the version of SourceKitten to |
This is still an issue even with SourceKitten 0.26.0. See #2896. I will try to take a look later today. |
@marcelofabri #2896 appears to fix the issue for me |
Thanks for verifying, @Fryie 🚀 |
New Issue Checklist
Describe the bug
The reason is that the XML support has been moved to a separate package on Linux, which breaks something in the transitive dependency SWXMLHash, where the issue has apparently been fixed, but of course this package is still using an old version.
Since the package is not a direct dependency of SwiftLint, it probably needs to be fixed in some other package first, but I have no idea how to find out which dependency pulls this in, so apologies for filing this here.
The text was updated successfully, but these errors were encountered: