Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rule request] Closure expressions should have consistent spacing. #770

Closed
masters3d opened this issue Aug 23, 2016 · 2 comments · Fixed by #807
Closed

[rule request] Closure expressions should have consistent spacing. #770

masters3d opened this issue Aug 23, 2016 · 2 comments · Fixed by #807
Labels
rule-request Requests for a new rules.

Comments

@masters3d
Copy link
Contributor

{$0.contains(location)} // violation
vs
{ $0.contains(location) } // okay
@masters3d masters3d changed the title [rule request] Content of branches {x} should have whitespace { x } [rule request] Content of braces {x} should have whitespace { x } Aug 23, 2016
@masters3d
Copy link
Contributor Author

I think the name for this rule should be: curly-braces-spacing

xjamundx/eslint@ab78e32

@masters3d
Copy link
Contributor Author

I actually think a better name would be closure-spacing

https://github.com/raywenderlich/swift-style-guide#closure-expressions

@masters3d masters3d changed the title [rule request] Content of braces {x} should have whitespace { x } [rule request] Closure expressions should have consistent spacing. Aug 26, 2016
@jpsim jpsim added the rule-request Requests for a new rules. label Aug 27, 2016
@jpsim jpsim mentioned this issue Aug 30, 2016
Merged
@masters3d masters3d mentioned this issue Sep 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule-request Requests for a new rules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added closure-spacing-rule masters3d/SwiftLint
2 participants
@jpsim @masters3d