Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section on performance testing responsibility in contributing.md #774

Closed
jpsim opened this issue Aug 24, 2016 · 2 comments
Closed

Add section on performance testing responsibility in contributing.md #774

jpsim opened this issue Aug 24, 2016 · 2 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@jpsim
Copy link
Collaborator

jpsim commented Aug 24, 2016

We accidentally shipped a major performance regression in 0.11.2 (see #772). This would've been caught by perf tests (#376), but until we have those, we could at least add a paragraph to contributing.md requiring that PRs post a before/after metric of IntegrationTests.testSwiftLintLints(). Maybe a PR template that has placeholders for this would help too.
@jpsim jpsim added the enhancement Ideas for improvements of existing features and rules. label Aug 24, 2016
@marcelofabri
Copy link
Collaborator

Is this still valid now that we have performance tests?

@jpsim
Copy link
Collaborator Author

jpsim commented Jan 9, 2017

No, let's close until/if we notice that the perf tests on Circle aren't sufficient.

@jpsim jpsim closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsim @marcelofabri