Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): fix open command documentation typo (#716) #716

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

clelange
Copy link
Contributor

@clelange clelange commented Apr 5, 2024

Fix typo that I spotted during the demo this morning.

@clelange
Copy link
Contributor Author

clelange commented Apr 5, 2024

Does this need an issue for commitlint to be happy?

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.62%. Comparing base (3465eb0) to head (9a4dfc2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   58.62%   58.62%           
=======================================
  Files          24       24           
  Lines        2393     2393           
=======================================
  Hits         1403     1403           
  Misses        990      990           
Files Coverage Δ
reana_client/cli/workflow.py 63.73% <ø> (ø)

@tiborsimko
Copy link
Member

Does this need an issue for commitlint to be happy?

We are attaching the PR number at the end, basically simulating GitHub's squash-merge behaviour. This is so that the PR would be linked in the Release-Please-compiled changelog items. Please see some details on the commit message here: https://github.com/reanahub/reana/wiki/Tips-for-Git#commit-message-style

No worries though, we can do these little cosmetic things while merging. E.g. in this case, I would suggest the commit log message:

docs(cli): fix `open` command documentation typo (#716)

(Note also the usage of docs instead of fix type, since this is a documentation-only change.)

I'll amend your PR in the above sense and merge.

tiborsimko added a commit to tiborsimko/docs.reana.io that referenced this pull request Apr 7, 2024
tiborsimko added a commit to tiborsimko/docs.reana.io that referenced this pull request Apr 7, 2024
@tiborsimko tiborsimko changed the title fix(cli): typo docs(cli): fix open command documentation typo (#716) Apr 7, 2024
@tiborsimko tiborsimko merged commit 9a4dfc2 into master Apr 7, 2024
55 checks passed
@tiborsimko tiborsimko deleted the cli_fix_typo branch April 7, 2024 10:47
tiborsimko pushed a commit to tiborsimko/reana-client that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants